From 80ecee5c4a43fe7c7ca28c1033f5f0012c3e636e Mon Sep 17 00:00:00 2001 From: Marcus Date: Tue, 24 Feb 2026 21:27:37 +0000 Subject: [PATCH] fix: quote variables and use zsh idioms in shell config - Quote ZINIT_HOME in plugin manager setup - Quote $1 in mkcd function - Use [[ ]] instead of [ ] in yazi wrapper (zsh idiom) - Remove double blank line in .vimrc Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift --- .vimrc | 1 - .zshrc | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.vimrc b/.vimrc index 5bffd40..1ec65f3 100644 --- a/.vimrc +++ b/.vimrc @@ -24,7 +24,6 @@ set backupdir=~/.vim/backup// set nobackup set mouse=a " mouse support - noremap noremap noremap diff --git a/.zshrc b/.zshrc index daf6641..8a7ccce 100644 --- a/.zshrc +++ b/.zshrc @@ -36,8 +36,8 @@ zmodload zsh/stat # plugin manager ZINIT_HOME="${XDG_DATA_HOME:-${HOME}}/.zinit.git" -[ ! -d $ZINIT_HOME ] && mkdir -p "$(dirname $ZINIT_HOME)" -[ ! -d $ZINIT_HOME/.git ] && git clone https://github.com/zdharma-continuum/zinit.git "$ZINIT_HOME" +[ ! -d "$ZINIT_HOME" ] && mkdir -p "$(dirname $ZINIT_HOME)" +[ ! -d "$ZINIT_HOME/.git" ] && git clone https://github.com/zdharma-continuum/zinit.git "$ZINIT_HOME" source "${ZINIT_HOME}/zinit.zsh" zinit light zsh-users/zsh-autosuggestions @@ -158,7 +158,7 @@ function y() { local tmp="$(mktemp -t "yazi-cwd.XXXXXX")" cwd command yazi "$@" --cwd-file="$tmp" IFS= read -r -d '' cwd < "$tmp" - [ "$cwd" != "$PWD" ] && [ -d "$cwd" ] && builtin cd -- "$cwd" + [[ "$cwd" != "$PWD" ]] && [[ -d "$cwd" ]] && builtin cd -- "$cwd" rm -f -- "$tmp" } @@ -179,7 +179,7 @@ function clip { function mkcd { : "${1:?where?}" [[ -e $1 ]] && { echo "file exists"; return 1 } - mkdir -p $1 && cd $1 + mkdir -p "$1" && cd "$1" } function cdtmp {